> + /* look at watchdog state field */
> + wdog &= 12ULL;
Magic value? Probably could use a define.
> + if (core_is_stuck[core_num] == 1) {
> + dev_err(&oct->pci_dev->dev,
> + "ERROR: Octeon core %d is
> stuck!\n",
> + core_num);
> + core_is_stuck[core_num] =
> + 2; /* 2 means we have printk'd
> + * an error; so no need to
> + * repeat the same printk
> + */
Likewise.
> + if (!(scratch1 & 4ULL)) {
> + /* Bit 2 of SLI_SCRATCH_1 is a flag that indicates that
> + * the lio watchdog kernel thread is running for this
> + * NIC. Each NIC gets one watchdog kernel thread.
> + */
> + scratch1 |= 4ULL;
Likewise.
