Thanks for the patch. Acked-by: Sudarsana Reddy Kalluru <sudarsana.kall...@qlogic.com>
-----Original Message----- From: Wei Yongjun [mailto:weiyj...@gmail.com] Sent: 12 August 2016 05:00 To: Yuval Mintz <yuval.mi...@qlogic.com>; Ariel Elior <ariel.el...@qlogic.com>; Sudarsana Kalluru <sudarsana.kall...@qlogic.com> Cc: Wei Yongjun <weiyj...@gmail.com>; Dept-Eng Everest Linux L2 <dept-engeverestlinu...@qlogic.com>; netdev <netdev@vger.kernel.org> Subject: [PATCH -next] qed: Fix possible memory leak in qed_dcbnl_get_ieee_pfc() 'dcbx_info is malloced in qed_dcbnl_get_ieee_pfc() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: a1d8d8a51e83 ("qed: Add dcbnl support.") Signed-off-by: Wei Yongjun <weiyj...@gmail.com> --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c index 226cb08..b900dfb 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c @@ -1968,6 +1968,7 @@ static int qed_dcbnl_get_ieee_pfc(struct qed_dev *cdev, if (!dcbx_info->operational.ieee) { DP_INFO(hwfn, "DCBX is not enabled/operational in IEEE mode\n"); + kfree(dcbx_info); return -EINVAL; }
