Before this patch:

 # ./tc/tc actions add action drop index 11
 RTNETLINK answers: File exists
 We have an error talking to the kernel
 Command "(null)" is unknown, try "tc actions help".

After this patch:

 # ./tc/tc actions add action drop index 11
 RTNETLINK answers: File exists
 We have an error talking to the kernel

Cc: Stephen Hemminger <shemm...@brocade.com>
Cc: Jamal Hadi Salim <j...@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
---
 tc/m_action.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tc/m_action.c b/tc/m_action.c
index 24f8b5d..bb19df8 100644
--- a/tc/m_action.c
+++ b/tc/m_action.c
@@ -623,14 +623,12 @@ int do_action(int argc, char **argv)
                        act_usage();
                        return -1;
                } else {
-
-                       ret = -1;
-               }
-
-               if (ret < 0) {
                        fprintf(stderr, "Command \"%s\" is unknown, try \"tc 
actions help\".\n", *argv);
                        return -1;
                }
+
+               if (ret < 0)
+                       return -1;
        }
 
        return 0;
-- 
2.1.0

Reply via email to