On Mon, 8 Aug 2016 09:19:21 +0200 Jiri Pirko <j...@resnulli.us> wrote:
> Sat, Jul 23, 2016 at 06:46:59PM CEST, step...@networkplumber.org wrote: > >On Fri, 22 Jul 2016 18:34:29 +0200 > >Jiri Pirko <j...@resnulli.us> wrote: > > > >> From: Jiri Pirko <j...@mellanox.com> > >> > >> In order to not confuse reader, write help messages into stderr. > >> > >> Signed-off-by: Jiri Pirko <j...@mellanox.com> > > > >This does make devlink consistent with other parts of iproute2. > >But the most common coding standards, back to Unix, and GNU are > >that help messages should go to stdout so that: > > $ ip -h | more > >would work as expected. > > The thing is I wanted to make stdout only for json. Putting non-json > help out there does not look correct to me. Is it? > I applied both of these patches, just wanted to mention that iproute2 is not following the GNU convention. At this point, it really doesn't matter, there are arguments to be made for both behaviors.