I have no problem with this series in general and wanted to put it in before
closing the lid on 4.7 version, BUT.

This patch generates warnings when built on Debian Strech with gcc-5
 
ipila.c: In function ‘ila_parse_opt.constprop’:
ipila.c:205:2: warning: ‘locator_match’ may be used uninitialized in this 
function [-Wmaybe-uninitialized]
  addattr64(n, 1024, ILA_ATTR_LOCATOR_MATCH, locator_match);

        if (matches(*argv, "add") == 0)
> +             return do_add(argc-1, argv+1);
> +     if (matches(*argv, "delete") == 0)
> +             return do_del(argc-1, argv+1);
> +     if (matches(*argv, "list") == 0)
> +             return do_list(argc-1, argv+1);
> +     if (matches(*argv, "help") == 0)
> +             usage();
> +
> +     fprintf(stderr, "Command \"%s\" is unknown, try \"ip ila help\".\n",
> +             *argv);
> +     exit(-1);
> +}
> +

You also added a blank line at end of file.

Please fix this and resubmit the series.

Reply via email to