On 08/05/2016 07:34 PM, ggar...@abra.uab.cat wrote:

From: Gerard Garcia <ggar...@deic.uab.cat>

Remove unnecessary use of enable/disable callback notifications
and the incorrect more space available check.

The virtio_transport_tx_work handles when the TX virtqueue
has more buffers available.

Signed-off-by: Gerard Garcia <ggar...@deic.uab.cat>
---
 net/vmw_vsock/virtio_transport.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index 699dfab..b7a1055 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
[...]
@@ -118,13 +114,12 @@ virtio_transport_send_pkt_work(struct work_struct *work)
                }

                ret = virtqueue_add_sgs(vq, sgs, out_sg, in_sg, pkt, 
GFP_KERNEL);
+               /* Usually this means that there is no more space available in
+                * the vq */

   The preferred comment style in the networking code is:

/* bla
 * bla
 */

[...]

MBR, Sergei

Reply via email to