> +static void cn23xx_bar1_idx_setup(struct octeon_device *oct, u64 core_addr,
...
> + if (valid == 0) {
!valid
...
> + WRITE_ONCE(bar1, lio_pci_readq(
> + oct, CN23XX_PEM_BAR1_INDEX_REG(oct->pcie_port, idx)));
> + lio_pci_writeq(oct, (READ_ONCE(bar1) & 0xFFFFFFFEULL),
> + CN23XX_PEM_BAR1_INDEX_REG(oct->pcie_port,
> idx));
> + WRITE_ONCE(bar1, lio_pci_readq(
> + oct, CN23XX_PEM_BAR1_INDEX_REG(oct->pcie_port, idx)));
Indentation issues?
> +static u32 cn23xx_update_read_index(struct octeon_instr_queue *iq) {
...
> + /* reset the cnt as a part of napi enable interrupt or check_iq_db */
> + /*writeq(pkt_in_done | CN23XX_INTR_RESEND, iq->inst_cnt_reg);*/
Looks like this comment should be removed.