>On Wednesday 27 July 2016 07:50 AM, Peter Chen wrote:
>> of_node_put needs to be called when the device node which is got from
>> of_parse_phandle has finished using.
>>
>> Signed-off-by: Peter Chen <peter.c...@nxp.com>
>> ---
>> drivers/net/ethernet/ti/davinci_emac.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/ti/davinci_emac.c
>> b/drivers/net/ethernet/ti/davinci_emac.c
>> index c6c5465..d8cb9d0 100644
>> --- a/drivers/net/ethernet/ti/davinci_emac.c
>> +++ b/drivers/net/ethernet/ti/davinci_emac.c
>> @@ -1571,6 +1571,7 @@ static int emac_dev_open(struct net_device *ndev)
>> if (priv->phy_node) {
>> phydev = of_phy_connect(ndev, priv->phy_node,
>> &emac_adjust_link, 0, 0);
>> + of_node_put(priv->phy_node);
>> if (!phydev) {
>> dev_err(emac_dev, "could not connect to phy %s\n",
>> priv->phy_node->full_name);
>>
>
>phy_node is accessed in case of of_phy_connect() returns error, so it has to be
>moved after the dev_err log
>
Yeah, you are right. I will change it, thanks.
Peter
