On Mon, Jul 18, 2016 at 11:03:40AM +0200, Charles-Antoine Couret wrote: Hi Charles-Antoine
Looking good. Just one nitpick. > /* marvell_read_status You missed changing this name above. > * > - * Generic status code does not detect Fiber correctly! > * Description: > * Check the link, then figure out the current state > * by comparing what we advertise with what the link partner > * advertises. Start by checking the gigabit possibilities, > * then move on to 10/100. > */ > -static int marvell_read_status(struct phy_device *phydev) > +static int marvell_read_status_page(struct phy_device *phydev, int page) Reviewed-by: Andrew Lunn <and...@lunn.ch> Andrew