On Thu, Jul 14, 2016 at 11:38 AM, Jason Baron <jba...@akamai.com> wrote:
>
> From: Jason Baron <jba...@akamai.com>
>
> The per-socket rate limit for 'challenge acks' was introduced in the
> context of limiting ack loops:
>
> commit f2b2c582e824 ("tcp: mitigate ACK loops for connections as tcp_sock")
>
> And I think it can be extended to rate limit all 'challenge acks' on a
> per-socket basis.
>
> Since we have the global tcp_challenge_ack_limit, this patch allows for
> tcp_challenge_ack_limit to be set to a large value and effectively rely on
> the per-socket limit, or set tcp_challenge_ack_limit to a lower value and
> still prevents a single connections from consuming the entire challenge ack
> quota.
>
> It further moves in the direction of eliminating the global limit at some
> point, as Eric Dumazet has suggested. This a follow-up to:
> Subject: tcp: make challenge acks less predictable
>
> Cc: Eric Dumazet <eduma...@google.com>
> Cc: David S. Miller <da...@davemloft.net>
> Cc: Neal Cardwell <ncardw...@google.com>
> Cc: Yuchung Cheng <ych...@google.com>
> Cc: Yue Cao <ycao...@ucr.edu>
> Signed-off-by: Jason Baron <jba...@akamai.com>
> ---
> net/ipv4/tcp_input.c | 39 ++++++++++++++++++++++-----------------
> 1 file changed, 22 insertions(+), 17 deletions(-)
Sounds good to me.
Acked-by: Neal Cardwell <ncardw...@google.com>
thanks,
neal
