Tue, Jul 12, 2016 at 06:38:26PM CEST, rost...@goodmis.org wrote: >On Tue, 12 Jul 2016 18:05:03 +0200 >Jiri Pirko <j...@resnulli.us> wrote: > >> From: Jiri Pirko <j...@mellanox.com> >> >> Define a tracepoint and allow user to trace messages going to and from >> hardware associated with devlink instance. >> >> Signed-off-by: Jiri Pirko <j...@mellanox.com> >> --- >> v1->v2: >> - Use EXPORT_TRACEPOINT_SYMBOL_GPL instead of a wrapper function >> as suggested by David Ahern and Steven Rostedt > >FYI, you can use the Suggested-by: tag too ;-)
Thought that the purpose of that tag is if someone suggested the whole patch existence. <snip> >> +/* This part must be outside protection */ >> +#include <trace/define_trace.h> >> + >> +#else /* CONFIG_NET_DEVLINK */ >> + >> +#if !defined(_TRACE_DEVLINK_H) >> +#define _TRACE_DEVLINK_H > >Ah, I guess you do need header protection here. Yes, you do. > >OK, looks good to me. > >Acked-by: Steven Rostedt <rost...@goodmis.org> Thanks Steven!
