On Mon, 11 Jul 2016 15:18:47 +0200 Jiri Pirko <j...@resnulli.us> wrote:
> diff --git a/include/net/devlink.h b/include/net/devlink.h > index c99ffe8..865ade6 100644 > --- a/include/net/devlink.h > +++ b/include/net/devlink.h > @@ -115,6 +115,8 @@ struct devlink *devlink_alloc(const struct devlink_ops > *ops, size_t priv_size); > int devlink_register(struct devlink *devlink, struct device *dev); > void devlink_unregister(struct devlink *devlink); > void devlink_free(struct devlink *devlink); > +void devlink_trace_hwmsg(const struct devlink *devlink, bool incoming, > + unsigned long type, const u8 *buf, size_t len); > int devlink_port_register(struct devlink *devlink, > struct devlink_port *devlink_port, > unsigned int port_index); > @@ -154,6 +156,12 @@ static inline void devlink_free(struct devlink *devlink) > kfree(devlink); > } > > +static inline void devlink_trace_hwmsg(const struct devlink *devlink, > + bool incoming, unsigned long type, > + const u8 *buf, size_t len); > +{ > +} > + I'm assuming the !CONFIG_NET_DEVLINK was never tested, because the above probably wont build, and if it did, it would be wrong. -- Steve