> > Hi, > > > > This patch series adds common library module(libcxgb.ko) > > for Chelsio drivers to remove duplicate code. > > > > This series moves common iSCSI DDP Page Pod manager > > code from cxgb4.ko to libcxgb.ko, earlier this code > > was used by only cxgbit.ko now it is used by > > three Chelsio iSCSI drivers cxgb3i, cxgb4i, cxgbit. > > > > In future this module will have common connection > > management and hardware specific code that can > > be shared by multiple Chelsio drivers(cxgb4, > > csiostor, iw_cxgb4, cxgb4i, cxgbit). > > > > Please review. > > As currently implemented the user is prompted for the Kconfig symbol > for the library. That really needs to be hidden from the user and > they should be able to select these drivers without having to know > about this implementation detail at all.
Maybe adding something like: select CHELSIO_LIB to the Kconfig files for the drivers that are depenedent on CHELSIO_LIB?
