On Wed, Jul 06, 2016 at 10:27:29AM +0800, Herbert Xu wrote:
> On Tue, Jul 05, 2016 at 12:13:03PM -0700, David Miller wrote:
> > From: Vegard Nossum <vegard.nos...@oracle.com>
> > Date: Tue, 5 Jul 2016 10:18:08 +0200
> >
> > > If we hit any of the error conditions inside xfrm_dump_sa(), then
> > > xfrm_state_walk_init() never gets called. However, we still call
> > > xfrm_state_walk_done() from xfrm_dump_sa_done(), which will crash
> > > because the state walk was never initialized properly.
> > >
> > > We can fix this by setting cb->args[0] only after we've processed the
> > > first element and checking this before calling xfrm_state_walk_done().
> > >
> > > Fixes: d3623099d3 ("ipsec: add support of limited SA dump")
> > > Cc: Nicolas Dichtel <nicolas.dich...@6wind.com>
> > > Cc: Steffen Klassert <steffen.klass...@secunet.com>
> > > Signed-off-by: Vegard Nossum <vegard.nos...@oracle.com>
> >
> > I assume Steffen will pick this up.
>
> I think Steffen said that he is going to be on vacation for two
> weeks starting this week.
Right, I'll take care of it as soon as I'm back.
