We can remove an unconditional jump, checking for the error condition instead of checking for success
Signed-off-by: Paolo Abeni <pab...@redhat.com> --- net/ipv4/udp_offload.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c index 81f253b..9c37338 100644 --- a/net/ipv4/udp_offload.c +++ b/net/ipv4/udp_offload.c @@ -268,11 +268,9 @@ struct sk_buff **udp_gro_receive(struct sk_buff **head, struct sk_buff *skb, rcu_read_lock(); sk = (*lookup)(skb, uh->source, uh->dest); - if (sk && udp_sk(sk)->gro_receive) - goto unflush; - goto out_unlock; + if (!sk || !udp_sk(sk)->gro_receive) + goto out_unlock; -unflush: flush = 0; for (p = *head; p; p = p->next) { -- 1.8.3.1