Francois Romieu wrote:

    ipg: remove forward declarations
It makes no sense in a new driver. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>

Ack.

    ipg: replace #define with enum
Added some underscores to improve readability. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>

Nack. Register names in code should match those used in the documentation (even if they are a bit unreadable). Though I will conceed that the available datasheet doesn't actually describe the majority of the registers.

    ipg: removal of useless #defines
IPG_TX_NOTBUSY apart (one occurence in ipg.c), the #defines appear
    nowhere in the sources.

Ack.

    ipg: redundancy with mii.h - take II
Replace a bunch of #define with their counterpart from mii.h It is applied to the usual MII registers this time.

Ack.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to