On Wed, Jun 29, 2016 at 03:39:37PM -0700, Andy Lutomirski wrote: > > I don't care about TCP MD5 performance at all. Ease of maintenance is > nice, though, and maybe there are other places in the kernel where > performance does matter.
TCP MD5 is using ahash because it touches SG lists. Touching SG lists is a pretty reliable indicator for hashing a large amount of data. In fact TCP MD5 hashes the entire packet content so we're talking about ~1000 bytes, just like IPsec. Therefore it is completely pointless to use something like shash for it as shash is only meant to be used for those hashing less one block of data or less. If you're aware of any other user in the kernel that is using ahash and is hashing a small amount of data in aggregate (not per update) please let me know. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
