On 06/14/2016 10:27 PM, Sergei Shtylyov wrote:
If the interrupt configuration isn't set and we are using the
internal phy, then we need to poll the phy to reliably detect
phy state changes.
Signed-off-by: Jeremy Linton <[email protected]>
---
drivers/net/ethernet/smsc/smsc911x.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c
b/drivers/net/ethernet/smsc/smsc911x.c
index 8af2556..369dc7d 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -1020,6 +1020,9 @@ static int smsc911x_mii_probe(struct net_device *dev)
return -ENODEV;
}
+ if ((!phydev->irq) && (!pdata->using_extphy))
Inner parens aren't needed at all.
Hm, 'phydev->irq' shouldn't be 0 in the first place. It seems to me we
should correctly initialize 'pdata->phy_irq[]' in smsc911x_mii_init()...
And looking at that array, I doubt it's really useful for anything... And
the memcpy() there seems buggy as well -- it copies just 4 bytes of this array
to 'pdata->mii_bus->irq'. I do care about this driver, so might be a good idea
to clean it up a bit...
MBR, Sergei
