Re: [PATCH net] fib_rules: don't break ECN with TOS rules

[Hannes Frederic Sowa]

On Mon, Jun 13, 2016, at 00:18, David Ahern wrote:
> On 6/11/16 3:10 PM, Hannes Frederic Sowa wrote:
> > @@ -215,6 +216,9 @@ static int fib4_rule_configure(struct fib_rule *rule, 
> > struct sk_buff *skb,
> >     rule4->dst_len = frh->dst_len;
> >     rule4->dstmask = inet_make_mask(rule4->dst_len);
> >     rule4->tos = frh->tos;
> > +   if (!INET_ECN_ignore(rule4->tos))
> > +           pr_warn("ipv4: never matching ipv4 rule with match for %x 
> > added\n",
> > +                   rule4->tos);
> >
> 
> The wording of the warning message is not very clear on what the problem
> is.

I will redesign this whole patch and will improve those warnings, too.

Thanks,
Hannes