From: Lucas Stach <l.st...@pengutronix.de> Sent: Thursday, June 09, 2016 5:35 PM > To: Fugang Duan <fugang.d...@nxp.com>; Shawn Guo <shawn...@kernel.org> > Cc: devicet...@vger.kernel.org; patchwork-...@pengutronix.de; > ker...@pengutronix.de; linux-arm-ker...@lists.infradead.org; > netdev@vger.kernel.org > Subject: Re: [PATCH v2 1/2] ARM: imx6: disable deeper idle states when FEC is > active w/o HW workaround > > Hi Fugang, > > Am Montag, den 06.06.2016, 02:00 +0000 schrieb Fugang Duan: > > From: Lucas Stach <l.st...@pengutronix.de> Sent: Saturday, June 04, > > 2016 12:31 AM > > > > > > To: Shawn Guo <shawn...@kernel.org>; Fugang Duan <fugang.duan@nxp.c > > > om> > > > Cc: devicet...@vger.kernel.org; patchwork-...@pengutronix.de; > > > ker...@pengutronix.de; linux-arm-ker...@lists.infradead.org; > > > netdev@vger.kernel.org > > > Subject: [PATCH v2 1/2] ARM: imx6: disable deeper idle states when > > > FEC is active w/o HW workaround > > > > > > The i.MX6 Q/DL has an erratum (ERR006687) that prevents the FEC from > > > waking the CPUs when they are in wait(unclocked) state. As the > > > hardware workaround isn't applicable to all boards, disable the > > > deeper idle state when the workaround isn't present and the FEC is > > > in use. > > > > > > This allows to safely run a kernel with CPUidle enabled on all > > > i.MX6 boards. > > > > > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > > > Acked-by: David S. Miller <da...@davemloft.net> (for network > > > changes) > > > --- > > [...] > > > Hi, Lucas, > > > > FEC irq cannot wake up CPUs when system is in wait mode. But we can > > use GPIO_6 for FEC interrupt that GPIO irq wake up CPUs. > > No need to disable wait mode as your such patches. > > > > You just config the gpio irq like below patches: > > bc20a5d6da71 (ARM: dts: imx6qdl-sabreauto: use GPIO_6 for FEC > > interrupt.) > > 6261c4c8f13e (ARM: dts: imx6qdl-sabrelite: use GPIO_6 for FEC > > interrupt.) > > > Please look at the description of this series again. The changes don't > disable the > deeper idle states on boards where the HW waorkaround is available. There is a > large number of boards in the wild which can not use the HW workaround, as > they use GPIO_6 for other purposes. The aim of this series is to have an > automatic software workaround available for those boards. > > Regards, > Lucas
I see. My concern is the wild boards why don't follow NXP HW reference guide. For the patch itself, it is fine for me to fix the wild boards issue. Acked-by: Fugang Duan <fugang.d...@nxp.com>
