Jeff Kirsher <[EMAIL PROTECTED]> :
[...]
> diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
> index c83271b..a696c33 100644
> --- a/drivers/net/ixgb/ixgb.h
> +++ b/drivers/net/ixgb/ixgb.h
[...]
> @@ -192,6 +197,7 @@ struct ixgb_adapter {
>
> /* structs defined in ixgb_hw.h */
> struct ixgb_hw hw;
> + u16 msg_enable;
> struct ixgb_hw_stats stats;
> #ifdef CONFIG_PCI_MSI
> boolean_t have_msi;
> diff --git a/drivers/net/ixgb/ixgb_ethtool.c b/drivers/net/ixgb/ixgb_ethtool.c
> index d38ade5..e8d83de 100644
> --- a/drivers/net/ixgb/ixgb_ethtool.c
> +++ b/drivers/net/ixgb/ixgb_ethtool.c
> @@ -251,6 +251,20 @@ ixgb_set_tso(struct net_device *netdev,
> }
> #endif /* NETIF_F_TSO */
>
> +static uint32_t
> +ixgb_get_msglevel(struct net_device *netdev)
> +{
> + struct ixgb_adapter *adapter = netdev->priv;
> + return adapter->msg_enable;
> +}
> +
> +static void
> +ixgb_set_msglevel(struct net_device *netdev, uint32_t data)
> +{
> + struct ixgb_adapter *adapter = netdev->priv;
> + adapter->msg_enable = data;
> +}
> +
Minor nits:
- you may consider removing the u{8/16/32} in drivers/net/ixgb
for consistency sake in a different patch (there is a strong
majority of uint_something in the driver).
- s/netdev->priv/netdev_priv(netdev)/ ?
[...]
> @@ -486,8 +495,7 @@ ixgb_probe(struct pci_dev *pdev,
> netif_carrier_off(netdev);
> netif_stop_queue(netdev);
>
> - printk(KERN_INFO "%s: Intel(R) PRO/10GbE Network Connection\n",
> - netdev->name);
> + DPRINTK(PROBE, INFO, "Intel(R) PRO/10GbE Network Connection\n");
It could probably be factored out with ixgb_driver_string.
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
