The field autoneg of pauseparam is not initialized in some
implementations of get_pauseparam(), but the whole object is
copied to userland.

Signed-off-by: Kangjie Lu <k...@gatech.edu>
---
 net/core/ethtool.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index f426c5a..84544bd 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -1723,7 +1723,10 @@ static noinline_for_stack int 
ethtool_set_channels(struct net_device *dev,
 
 static int ethtool_get_pauseparam(struct net_device *dev, void __user 
*useraddr)
 {
-       struct ethtool_pauseparam pauseparam = { ETHTOOL_GPAUSEPARAM };
+       struct ethtool_pauseparam pauseparam;
+
+       memset(&pauseparam, 0, sizeof(pauseparam));
+       pauseparam.cmd = ETHTOOL_GPAUSEPARAM;
 
        if (!dev->ethtool_ops->get_pauseparam)
                return -EOPNOTSUPP;
-- 
1.9.1

Reply via email to