❦ 30 mai 2016 11:23 CEST, Nicolas Dichtel <[email protected]> :
>> @@ -466,6 +462,10 @@ static int veth_newlink(struct net *src_net, struct
>> net_device *dev,
>>
>> priv = netdev_priv(peer);
>> rcu_assign_pointer(priv->peer, dev);
>> +
>> + err = rtnl_configure_link(peer, ifmp);
>> + if (err < 0)
>> + goto err_configure_peer;
> You should fix the error path. 'unregister_netdevice(dev)' is missing.
I am sending another patch to fix that. I am quite unsure if I do the
right thing here.
--
Don't stop with your first draft.
- The Elements of Programming Style (Kernighan & Plauger)
