Hi Kirtika,
On Sun, May 29, 2016 at 1:31 PM, Kirtika Ruchandani
<[email protected]> wrote:
> This patch fixes the following checkpatch.pl issues -
There's too much stuff here to quickly review, it'd be nice if you
could split this up into patches that do the following:
Space issues:
> - space preferred around that <operator>
> - no space needed after cast.
> - Alignment should match open parenthesis
> - suspect code indent for conditional statements
> - Statements should start on a tabstop
Braces:
> - braces {} should be used on all arms of this statement
Multiple assignments:
> - multiple assignments should be avoided
ether_addr_copy:
> - prefer ether_addr_copy over memcpy
Spelling:
> - correct spelling - 'implementation'
NULL comparisons:
> - comparison to NULL could be written as !foo
kcalloc vs kzalloc:
> - prefer kcalloc over kzalloc with multiply
Thanks,
--
Julian Calaby
Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/
