Hi Andrew, I like the s/phy/mdio/ renaming, but please move it in its own non-functional patch for easier reviewing.
Also, we may want to use this opportunity to get rid of some _ prefixed functions. It is hard to following the distinction between these two following signatures: int _mv88e6xxx_mdio_read(struct mv88e6xxx_priv_state *ps, int addr, int reg_num) and int mv88e6xxx_mdio_read(struct mii_bus *bus, int port, int regnum) (which take different first argument.) It would be great to introduce here the two low-level, bus-agnostic, SMI unlocked functions: mv88e6xxx_read() and mv88e6xxx_write(). Thanks, Vivien