Re: [RFC] NET: PHY: adds driver for Lantiq PHY11G

[Andrew Lunn]

> +static int lantiq_gphy_config_init(struct phy_device *phydev)
> +{
> +     int err;
> +
> +     /* Mask all interrupts */
> +     err = phy_write(phydev, MII_VR9_11G_IMASK, 0);
> +     if (err)
> +             return err;
> +
> +     /* Clear all pending interrupts */
> +     phy_read(phydev, MII_VR9_11G_ISTAT);
> +
> +     phy_write_mmd_indirect(phydev, 0x1e0, MDIO_MMD_VEND2, 0xc5);
> +     phy_write_mmd_indirect(phydev, 0x1e1, MDIO_MMD_VEND2, 0x67);
> +     phy_write_mmd_indirect(phydev, 0x1e2, MDIO_MMD_VEND2, 0x42);
> +     phy_write_mmd_indirect(phydev, 0x1e3, MDIO_MMD_VEND2, 0x10);
> +     phy_write_mmd_indirect(phydev, 0x1e4, MDIO_MMD_VEND2, 0x70);
> +     phy_write_mmd_indirect(phydev, 0x1e5, MDIO_MMD_VEND2, 0x03);
> +     phy_write_mmd_indirect(phydev, 0x1e6, MDIO_MMD_VEND2, 0x20);
> +     phy_write_mmd_indirect(phydev, 0x1e7, MDIO_MMD_VEND2, 0x00);
> +     phy_write_mmd_indirect(phydev, 0x1e8, MDIO_MMD_VEND2, 0x40);
> +     phy_write_mmd_indirect(phydev, 0x1e9, MDIO_MMD_VEND2, 0x20);

Please could you use #define's rather than magic numbers. That helps
document what these writes are doing.

         Thanks
                Andrew