Re: [PATCH] net: diag: Tell user if support for destroying TCP sockets is not enabled

[David Ahern]

On 5/16/16 6:49 PM, Lorenzo Colitti wrote:

On Tue, May 17, 2016 at 8:53 AM, David Ahern <d...@cumulusnetworks.com> wrote:

+#else
+static int tcp_diag_destroy(struct sk_buff *in_skb,
+                           const struct inet_diag_req_v2 *req)
+{
+       return -EOPNOTSUPP;
+}
 #endif

I don't understand why you need this. inet_diag_cmd_exact already
returns EOPNOTSUPP if tcp_diag_handler.destroy is NULL:

        else if (cmd == SOCK_DIAG_BY_FAMILY)
                err = handler->dump_one(in_skb, nlh, req);
        else if (cmd == SOCK_DESTROY && handler->destroy)
                err = handler->destroy(in_skb, req);
        else
                err = -EOPNOTSUPP;

Is this not working for some reason?

hmmm.... kernel patch is not needed. Suppression was happening in ss.