From: Lawrence Brakmo <bra...@fb.com> Date: Mon, 9 May 2016 14:46:12 -0700
> @@ -197,15 +197,15 @@ static void bictcp_state(struct sock *sk, u8 new_state) > /* Track delayed acknowledgment ratio using sliding window > * ratio = (15*ratio + sample) / 16 > */ > -static void bictcp_acked(struct sock *sk, u32 cnt, s32 rtt) > +static void bictcp_acked(struct sock *sk, const struct ack_sample *sample) > { > const struct inet_connection_sock *icsk = inet_csk(sk); > > if (icsk->icsk_ca_state == TCP_CA_Open) { > struct bictcp *ca = inet_csk_ca(sk); > > - cnt -= ca->delayed_ack >> ACK_RATIO_SHIFT; > - ca->delayed_ack += cnt; > + ca->delayed_ack += sample->pkts_acked - ^^ Trailing whitespace on that line. > + struct ack_sample sample = {.pkts_acked = pkts_acked, > + .rtt_us = ca_rtt_us}; Please put a space after the openning parenthesis and before the closing parenthesis.