Hello. On 5/9/2016 4:44 PM, Jesper Dangaard Brouer wrote:
It have always been required to call napi_alloc_skb from NAPI/softirq
It has.
context, which implies running with local_bh_disable'ed. Thus, this
Not local_bh_disable'd?
code path should already be well tested. But recent SKB bulk changes introduced will make this more volatile and bugs more subtle, if this is violated. To catch any driver violating this add a loud WARN_ON. Performance wise, I do worry about adding this runtime check code into the hotpath, of this highly optimized function call. I've
Hot path? My spellchecked trips here.
micro-benchmarked it with both IP-forwarding and local UDP delivery, and didn't see any regressions. It does adds extra code size (icache). add/remove: 0/0 grow/shrink: 1/0 up/down: 43/0 (43) function old new delta __napi_alloc_skb 461 504 +43 Signed-off-by: Jesper Dangaard Brouer <bro...@redhat.com>
[...] MBR, Sergei
