On 16-05-08 11:08 PM, Cong Wang wrote:
On Sun, May 8, 2016 at 10:26 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote:
[..]
+ aexists = tcf_hash_check(tn, parm->index, a, bind);
I think 'exists' is a better name than 'aexists', shorter and clear.
aexists is more specific (doesnt quiet apply to this case but has better
grep-ability).
exists looked too generic - initially I was going to have act_exists.
Yes, it is a tiny but ocd detail. Let me know if you feel strongly
and i will change it in next update.
+ if (aexists)
+ tcf_hash_release(a, bind);
Introduce a goto to reduce duplicated cleanup code?
Will do.
cheers,
jamal
