From: Petko Manolov <pet...@mip-labs.com> Date: Wed, 27 Apr 2016 14:24:48 +0300
> As noticed by Lincoln Ramsay <a1291...@gmail.com> some old (usb 1.1) Pegasus > based devices may actually return more bytes than the specified in the > datasheet > amount. That would not be a problem if the allocated space for the SKB was > equal to the parameter passed to usb_fill_bulk_urb(). Some poor bugger (i > really hope it was not me, but 'git blame' is useless in this case, so anyway) > decided to add '+ 8' to the buffer length parameter. Sometimes the usb > transfer > overflows and corrupts the socket structure, leading to kernel panic. > > The above doesn't seem to happen for newer (Pegasus2 based) devices which did > help this bug to hide for so long. > > The new default is to not include the CRC at the end of each received > package. > So far CRC has been ignored which makes no sense to do it in a first place. > > The patch is against v4.6-rc5 and was tested on ADM8515 device by transferring > multiple gigabytes of data over a couple of days without any complaints from > the > kernel. Please apply it to whatever net tree you deem fit. > > Changes since v1: > > - split the patch in two parts; > - corrected the subject lines; > > Changes since v2: > > - do not append CRC by default (based on a discussion with Johannes Berg); Series applied, thanks.
