[...] >> > -destroy_port: >> > - port->count -= 1; >> > - if (!port->count) >> > - macvlan_port_destroy(lowerdev); >> I think you still need this when it fails netdev_upper_dev_link(). The >> only thing you should remove is the label. > > I don't think so. I think the double decrement also occurred in this case. > unregister_netdevice invokes rollback_registered/macvlan_uninit > which does the decrement. > I thought macvlan_port_destroy() does not get called but it is called from macvlan_uninit(). So it's all good. Thanks.
> Thanks, > Francesco > >> > >> > return err; >> > } >> > -- >> > 1.8.1.4 >> >