drivers/net/dsa/mv88e6xxx.c: In function ‘mv88e6xxx_port_bridge_join’: drivers/net/dsa/mv88e6xxx.c:2184: warning: ‘err’ may be used uninitialized in this function
If netdev_notifier_changeupper_info.upper_dev is ever NULL, the bridge parameter will be NULL too, and the function will return an uninitialized value. Pre-initialize err to zero to fix this. Fixes: 207afda1b5036009 ("net: dsa: mv88e6xxx: share the same default FDB") Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- Can this actually happen? --- drivers/net/dsa/mv88e6xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c index a2904029cccc2949..5e572b3510b9483a 100644 --- a/drivers/net/dsa/mv88e6xxx.c +++ b/drivers/net/dsa/mv88e6xxx.c @@ -2181,7 +2181,7 @@ int mv88e6xxx_port_bridge_join(struct dsa_switch *ds, int port, struct net_device *bridge) { struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); - int i, err; + int i, err = 0; mutex_lock(&ps->smi_mutex); -- 1.9.1