Hi Marek, On 21 April 2016 at 14:12, Marek Vasut <ma...@denx.de> wrote: > Each and every driver which implements custom plat_data->init function > calls it exactly before stmmac_dvr_probe(). Trim down the code duplication > by calling the plat_data->init function from stmmac_dvr_probe() instead.
This is a result of my refactoring that started a long time ago, but the cleanup after this is still missing. I have a patch set that removes the init/exit callbacks from most of the drivers and replace them with proper PM and remove callbacks. Patches can be found here: https://github.com/manabian/linux-lpc/tree/net-next-dwmac. Note that the branch is outdated now and needs to be rebased. Sadly I haven't had much time to work on this lately. One of reason why I want to get rid of the init/exit callback is that it kinda forces the driver to call the same code for probe/resume and remove/suspend. This does not work for all drivers and this has to worked around in some drivers. In the end the dwmac drivers will look more standard Linux drivers and the stmmac will be used as library that drivers call into. Note that for "legacy" platforms which use the generic driver I intend to keep the init/exit callbacks since they are still used by Blackfin and Loongson, but new DT enabled drivers should not use these callbacks anymore. If you are willing to test my patch set for dwmac-socfpga(?). I'll see if I can create the time to send them to netdev early this week. regards, Joachim Eastwood
