On 4/22/16 10:14 AM, Mike Manning wrote:
commit f1705ec197e7 ("net: ipv6: Make address flushing on ifdown optional") added the option to retain user configured addresses on an admin down. A comment to one of the later revisions suggested using the IFA_F_PERMANENT flag rather than adding a user_managed boolean to the ifaddr struct. A side effect of this change is that link local and loopback addresses were also retained which was not part of the objective of the original changes. The commit 70af921db6f8 ("net: ipv6: Do not keep linklocal and loopback addresses") ensures that these are no longer kept. Similarly, the present fix ensures that these addresses are not incorrectly fixed up.Testing also with the recent patch in place to delete host routes on ifdown still shows that fixup of the LL & loopback addrs is incorrectly being attempted (and without that patch was causing a crash in fib6). Another approach to this is through code inspection by checking where the user_managed flag in the original dahern patch (which we have been using for nearly a year) has been replaced by checking IFA_F_PERMANENT. Fixes: f1705ec197e7 ("net: ipv6: Make address flushing on ifdown optional") Signed-off-by: Mike Manning <mmann...@brocade.com> --- net/ipv6/addrconf.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
Acked-by: David Ahern <d...@cumulusnetworks.com>
