From: Ben Greear <[EMAIL PROTECTED]>
Date: Wed, 12 Apr 2006 13:10:06 -0700
> What is the reasoning for this change? Is the compiler
> able to optomize the right-hand-side to a constant with your
> change in place?
>
> > - if (veth->h_vlan_proto != __constant_htons(ETH_P_8021Q)) {
> > + if (veth->h_vlan_proto != htons(ETH_P_8021Q)) {
> > return -EINVAL;
> > }
As a policy, Ben, we only use __constant_htons() in compile
time initializers of data structures. Otherwise we use the
normal htons().
That's why.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
