>> + flags |= (!!(edev->dev_info.common.num_hwfns > 1)) << >> + QEDE_PRI_FLAG_CMT;
> Why not just '='? >> + >> + return flags; > ... or direct return of the value above? Probably wanted to lay the basis for future flags. But you're right in that there's no need for it. I'll change it in V2. Thanks, Yuval
