On 4/7/16, 7:05 AM, "Nikolay Aleksandrov" <[email protected]> wrote:
>On 04/07/2016 12:36 AM, Debabrata Banerjee wrote: >> Set appropriate macvlan interface status based on lower device and our >> status. Can be up, down, or lowerlayerdown. >What about dormant ? > >That being said I understand the need to switch to lowerlayerdown when the >lower >device is in "down", which is basically the most important change of this >patch. >The rest is already handled by link watch based on carrier state. By now people >are used to having lowerlayerdown when there's no carrier, now it can also mean >that the lower device has been brought admin down. > >Here's another interesting state: >6: mac1@eth2: <NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP,DORMANT,M-DOWN> mtu >1500 qdisc noqueue state LOWERLAYERDOWN mode DEFAULT group default qlen 1000 >Prior to this patch the macvlan would stay in dormant state and it will also >propagate >to devices stacked on top of it. The no carrier issue gave me an idea. What if we just set no carrier on the macvlan device? This seems appropriate, but it doesn't directly address the dormant issue, although that could be a separate patch. Will this cause any new issues? It's very simple, new patch incoming.
