On Mon, 2016-04-04 at 21:27 -0400, David Miller wrote:
> From: "Samudrala, Sridhar" <sridhar.samudr...@intel.com>
> Date: Mon, 04 Apr 2016 15:32:37 -0700
> 
> > 
> > On 4/4/2016 3:14 PM, Jeff Kirsher wrote:
> > > 
> > > @@ -9190,41 +9148,37 @@ skip_sriov:
> > >     #endif
> > >           netdev->features = NETIF_F_SG |
> > > -                    NETIF_F_IP_CSUM |
> > > -                    NETIF_F_IPV6_CSUM |
> > > -                    NETIF_F_HW_VLAN_CTAG_TX |
> > > -                    NETIF_F_HW_VLAN_CTAG_RX |
> > >                              NETIF_F_TSO |
> > >                              NETIF_F_TSO6 |
> > >                              NETIF_F_RXHASH |
> > > -                    NETIF_F_RXCSUM;
> > > -
> > > - netdev->hw_features = netdev->features |
> > > NETIF_F_HW_L2FW_DOFFLOAD;
> > > +                    NETIF_F_RXCSUM |
> > > +                    NETIF_F_HW_CSUM |
> > > +                    NETIF_F_SCTP_CRC |
> > > +                    NETIF_F_HW_VLAN_CTAG_TX |
> > > +                    NETIF_F_HW_VLAN_CTAG_RX;
> > >   -       switch (adapter->hw.mac.type) {
> > > - case ixgbe_mac_82599EB:
> > > - case ixgbe_mac_X540:
> > > - case ixgbe_mac_X550:
> > > - case ixgbe_mac_X550EM_x:
> > > + if (hw->mac.type >= ixgbe_mac_82599EB)
> > >                   netdev->features |= NETIF_F_SCTP_CRC;
> > > -         netdev->hw_features |= NETIF_F_SCTP_CRC |
> > > -                                NETIF_F_NTUPLE |
> > > -                                NETIF_F_HW_TC;
> > > -         break;
> > > - default:
> > > -         break;
> > > - }
> > >   -       netdev->hw_features |= NETIF_F_RXALL;
> > > + /* copy netdev features into list of user selectable
> > > features */
> > > + netdev->hw_features |= netdev->features;
> > > + netdev->hw_features |= NETIF_F_RXALL |
> > > +                        NETIF_F_HW_L2FW_DOFFLOAD;
> > > +
> > > + if (hw->mac.type >= ixgbe_mac_82599EB)
> > > +         netdev->hw_features |= NETIF_F_NTUPLE;
> > looks like the cleanup missed moving NETIF_F_HW_TC flag here that
> > enables cls_u32 offloads via TC.
> Indeed, this is a regression.

I took care of it in v2.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to