Checkpatch suggests using ether_addr_copy over memcpy
to copy the mac address.

Acked-by: Michal Simek <[email protected]>
Acked-by: Nicolas Ferre <[email protected]>
Signed-off-by: Moritz Fischer <[email protected]>
---
 drivers/net/ethernet/cadence/macb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb.c 
b/drivers/net/ethernet/cadence/macb.c
index 2ba0934..01a8ffb 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -2973,7 +2973,7 @@ static int macb_probe(struct platform_device *pdev)
 
        mac = of_get_mac_address(np);
        if (mac)
-               memcpy(bp->dev->dev_addr, mac, ETH_ALEN);
+               ether_addr_copy(bp->dev->dev_addr, mac);
        else
                macb_get_hwaddr(bp);
 
-- 
2.7.4

Reply via email to