On Fri, Apr 1, 2016 at 3:56 PM, Martin KaFai Lau <ka...@fb.com> wrote: > + bh_lock_sock(sk); > + if (!sock_owned_by_user(sk)) > + ip6_datagram_dst_update(sk, false); > + bh_unlock_sock(sk);
My discussion with Eric shows that we probably don't need to hold this sock lock here, and you are Cc'ed in that thread, so 1) why do you still take the lock here? 2) why didn't you involve in our discussion if you disagree?