On 03/31/2016 01:59 PM, Eric Dumazet wrote:
On Thu, 2016-03-31 at 13:35 +0200, Daniel Borkmann wrote:

+static inline bool sock_owned_externally(const struct sock *sk)
+{
+       return sk->sk_flags & (1UL << SOCK_EXTERNAL_OWNER);
+}
+

Have you reinvented sock_flag(sl, SOCK_EXTERNAL_OWNER) ? ;)

Anyway, using a flag for this purpose sounds overkill to me.

Right.

Setting it is a way to 'fool' lockdep anyway...

Yep, correct, we'd be fooling the tun case, so this diff doesn't
really make it any better there.

Thanks,
Daniel

Reply via email to