Hi Greg, On Wed, Mar 30, 2016 at 12:24 AM, Greg Ungerer <g...@uclinux.org> wrote: > Hi Troy, > > Commit 55cd48c8 ('net: fec: stop the "rcv is not +last, " error > messages') adds a write to a register that is not present in all > implementations of the FEC hardware module. None of the ColdFire > SoC parts with the FEC module have the FTRL (0x1b0) register. > > Does this need a quirk flag to key access to this register of? > Or can you piggyback on the FEC_QUIRK_HAS_RACC flag?
Would the change below work on Coldfire? --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -943,8 +943,8 @@ fec_restart(struct net_device *ndev) else val &= ~FEC_RACC_OPTIONS; writel(val, fep->hwp + FEC_RACC); - } writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL); + } #endif /*