Hi Sergei, On 03/23/2016 11:39 AM, Sergei Shtylyov wrote: >> gpiod_reset = devm_gpiod_get_optional(dev, "reset", >> GPIOD_OUT_HIGH); > > We shouldn't call _optional() then, should we?
I could imagine the original intention was to be backward compatible. Indeed, if this call is not optional, systems using AT8030 and lacking a reset line on DT will have their behaviour affected. NOTE: they would still work because even if this driver fails to bind a generic one will take over. Best regards, Sebastian
