On Wed, 05 Apr 2006 10:31:14 -0700 Sanjeev Jorapur <[EMAIL PROTECTED]> wrote:
> On Wed, 2006-04-05 at 10:13 -0700, Stephen Hemminger wrote: > > On Wed, 05 Apr 2006 09:38:24 -0700 > > "Bryan O'Sullivan" <[EMAIL PROTECTED]> wrote: > > > > > On Sat, 2006-04-01 at 05:14 -0800, Linsys Contractor Amit S. Kale wrote: > > > > > > > We would like this driver to be inluded in mainline kernel. > > > > Kindly review it and feel free to get back to me for any > > > > feedback/queries/comments. > > > > > > Based on some light reading and my own recent experience, I'd estimate > > > that you have about three months of work ahead of you before this will > > > be suitable for merging. The code is a big mess as it stands. > > > > > > Also, next time you submit patches, please make life easier by including > > > a description in each patch of what's included, keep the patches below > > > 2500 lines long, and don't go back and randomly add bits and pieces > > > afterwards. > > > > > > > Or for a new driver, just make it one big piece and put it at a > > website for download and include linke. > > Thanks to everyone for your comments. We will incorporate the feedback > and repost the driver. The last time we posted our driver, it was on > a website with a link to download. We got just one comment back. So, > this time, we decided to inline the patches. > > Sanjeev. Inline is better, but looking at pieces is also annoying, so do both. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
