On 03/16/2016 11:59 AM, Jiri Benc wrote:
[...]
@@ -1807,6 +1809,7 @@ static struct dst_entry *vxlan6_get_route(struct 
vxlan_dev *vxlan,

        memset(&fl6, 0, sizeof(fl6));
        fl6.flowi6_oif = oif;
+       fl6.flowi6_tos = RT_TOS(tos);

Nothing against this but the reason it was missing was that it's never
used. Unless I'm missing something the IPv6 code does not use this
field at all for lookups.

This patch is not wrong but it's effectively dead code right now.
I'll be happy to be proven wrong, though.

Hmm, you're right, thanks for pointing this out! Guess I shouldn't have
judged from geneve_get_v6_dst(), where this seems wrong as well ... If
noone is faster than me, I can make a patch removing these from both,
vxlan and geneve for the route lookup itself. Maybe the flowi6_tos define
should just be removed in general for the time being until there's real
support.

(Sorry for answering after such long time, I'm catching up after a
vacation.)

  Jiri


Reply via email to