On Sat, Mar 19, 2016 at 4:58 PM, oulijun <ouli...@huawei.com> wrote: > On 2016/3/15 2:20, Parav Pandit wrote: >>>> >>>> Since SRQ is not supported in this driver version, can you keep >>>> remaining code base also to not bother about SRQ specifically >>>> poll_cq_one, modify_qp, destroy_qp etc? >>>> SRQ support can come as complete additional patch along with cmd_mask, >>>> callbacks and rest of the code. >>>> >>>> . >>> Sorry, I see your review in time. >>> Sure, SRQ is not supported in current roce driver. I have verified the >>> function >>> for RDMA. It is not influence. For your question, we need to analyse it >>> scientific. >>> after that, i will reply your doubt, is that ok? >> >> Yes. No problem. >> >> . >> > Hi, Parav Pandit > I have analyse and discuss with your reviewing. I considered that the srq > is only the > condition branch in verbs and without independent function, so reserved it.I > have delete the relative > function with srq independently. > if delete the branch operation with srq, it feel be inconvenient to > understand >
o.k. If I understand correctly, new patch will be without srq functionality. If thats the case, that makes review and maintainability easier. Thanks. Parav
