Linsys Contractor Amit S. Kale <[EMAIL PROTECTED]> :
> diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_brdcfg.h
> linux-2.6.16/drivers/net/netxen/netxen_brdcfg.h
> --- linux-2.6.16_orig/drivers/net/netxen/netxen_brdcfg.h 1969-12-31
> 16:00:00.000000000 -0800
> +++ linux-2.6.16/drivers/net/netxen/netxen_brdcfg.h 2006-03-24
> 14:13:57.000000000 -0800
[...]
> +typedef struct {
Yuck, typedef !
> + U32 header_version;
> +
> + U32 board_mfg;
> + //netxen_brdid_t board_id;
> + U32 board_type;
> + U32 board_num;
> + //netxen_chipid_t chip_id;
> + U32 chip_id;
> + U32 chip_minor;
> + U32 chip_major;
> + U32 chip_pkg;
> + U32 chip_lot;
The code uses U32, uint32_t, __uint32_t, u32.
What about always using the same type, especially the shortest one ?
[elsewhere in code]
> +#define PCI_DMA_64BIT 0xffffffffffffffffULL
> +#define PCI_DMA_32BIT 0x00000000ffffffffULL
DMA_{32/64}BIT_MASK should do the same.
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
