On Mon, 3 Apr 2006 19:27:25 +0200 Sam Ravnborg wrote:
> On Mon, Apr 03, 2006 at 10:27:32AM -0700, Randy.Dunlap wrote:
> > On Sun, 2 Apr 2006 23:12:03 +0200 Sam Ravnborg wrote:
> >
> > > On Mon, Mar 27, 2006 at 02:32:14PM -0800, Randy.Dunlap wrote:
> > > > >
> > > > > Sam, I am now seeing this error (not a WARNING like the previous ones
> > > > > were):
> > > > >
> > > > > drivers/net/typhoon.c:137: error: version causes a section type
> > > > > conflict
> > > > >
> > > > > but I don't see a real problem in the driver source file.
> > > > > Ideas, anyone?
> > > >
> > > > This happens for typhoon (above) as well as:
> > > >
> > > > drivers/net/natsemi.c:241: error: version causes a section type conflict
> > >
> > > I have taken a look at natsemi.c.
> > > Following patch fixes the error:
> > >
> > > diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
> > > index 7826afb..a36a15e 100644
> > > --- a/drivers/net/natsemi.c
> > > +++ b/drivers/net/natsemi.c
> > > @@ -372,7 +372,7 @@ enum pcistuff {
> > > static const struct {
> > > const char *name;
> > > unsigned long flags;
> > > -} natsemi_pci_info[] __devinitdata = {
> > > +} natsemi_pci_info[] /*__devinitdata*/ = {
> > > { "NatSemi DP8381[56]", PCI_IOTYPE },
> > > };
> > >
> > > The reason why gcc barfs over it seems to be conflicting sections
> > > between the function natsemi_probe1() where natsemi_pci_info[] is used
> > > and the section of natsemi_pci_info.
> > > But putting them in same section did not help.
> > >
> > > I'm a bit puzzeled what is going on. Randy - any insight in this?
> >
> > How weird. I can't reproduce this at all now. Tried several times.
> You need to build with CONFIG_HOTPLUG undefined to see it..
Thanks for the reminder. I see the problem.
gcc doesn't like for some __initdata to be const and others not, which is
what it's complaining about. Marking the driver <version> as 'const'
also fixes this problem. This needs to be done in:
typhoon, starfire, natsemi, and bnx2
Any volunteers to do this?
---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
