> -----Original Message----- > From: Ben Hutchings [mailto:b...@decadent.org.uk] > Sent: Sunday, March 13, 2016 9:25 AM > To: Keller, Jacob E <jacob.e.kel...@intel.com> > Cc: netdev <netdev@vger.kernel.org> > Subject: Re: [PATCH v2 4/4] ethtool: support setting default Rx flow > indirection table > > On Tue, 2016-02-16 at 21:22 +0000, Keller, Jacob E wrote: > > > Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com> > > --- > > > > Not sure if there is a mailing list for this, I sent this to the netdev > > list but forgot to Cc you on the ethtool change. > > I haven't been keeping up with netdev for a long time, but I have > recently set up filtering by subject so I can keep up with just the > ethtool-related messages. Still, patches for the ethtool command > should always be explicitly sent to me. > > > Dave applied the > > network core patches, but they're more or less useless unless we > > actually have the ability to request default setting using ethtool > > (which I extended to support "default" here) > > The patch was mangled (word-wrapped and modified white-space) in this > message, so I took the version in > <http://article.gmane.org/gmane.linux.network/398404/>. > > [...] > > @@ -3332,7 +3335,7 @@ static int do_srxfh(struct cmd_context *ctx) > > u32 entry_size = sizeof(rss_head.rss_config[0]); > > u32 num_weights = 0; > > > > - if (ctx->argc < 2) > > + if (ctx->argc < 1) > > exit_bad_args(); > [...] > > This means we might continue without having the required parameter > after "equal", "weight" or "hkey". But, having said that, since we're > only checking once before running the loop, we're already failing to > validate that properly. > > I've applied this, but could you please send another patch that adds > checks on ctx->argc within the loop and test cases in test-cmdline.c? > > Ben. >
Yes. Not sure how the patch got broken for you here, as I sent it using git-send-email. I will send the proposed fix above. Thanks, Jake
